[Traits] Encode all trait information for package dump #7701
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci test windows |
FranzBusch
force-pushed
the
fb-trait-dump
branch
from
e022b19
to
247d9f8
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
MaxDesiatov
reviewed
Jun 24, 2024
MaxDesiatov
reviewed
Jun 24, 2024
# Motivation We need to encode all trait related package manifest configuration so that it shows up in the `dump-package` output. # Modification This PR encodes the missing `traits` property of the manifest.
FranzBusch
force-pushed
the
fb-trait-dump
branch
from
247d9f8
to
0de56de
Compare
|
@swift-ci please test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Jun 24, 2024
MaxDesiatov
added
pending evolution proposal
enhancement
modules graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to encode all trait related package manifest configuration so that it shows up in the
dump-packageoutput.Modification
This PR encodes the missing
traitsproperty of the manifest.